I am trying to print a 2d character array and its just not working.
What am I doing wrong? I think i may need a pointer, but I am not sure
just how to do that.  All that it prints now, is that it starts on line
two and just prints one character at a time, which isn't right.  Thanks
in advance


char maze[][12]=
{{ '#', '#', '#', '#', '#', '#', '#', '#', '#', '#', '#', '#' },
{ '#', '.', '.', '.', '#', '.', '.', '.', '.', '.', '.', '#' },
{ '.', '.', '#', '.', '#', '.', '#', '#', '#', '#', '.', '#' },
{ '#', '#', '#', '.', '#', '.', '.', '.', '.', '#', '.', '#' },
{ '#', '.', '.', '.', '.', '#', '#', '#', '.', '#', '.', '.' },
{ '#', '#', '#', '#', '.', '#', '.', '#', '.', '#', '.', '#' },
{ '#', '.', '.', '#', '.', '#', '.', '#', '.', '#', '.', '#' },
{ '#', '#', '.', '#', '.', '#', '.', '#', '.', '#', '.', '#' },
{ '#', '.', '.', '.', '.', '.', '.', '.', '.', '#', '.', '#' },
{ '#', '#', '#', '#', '#', '#', '.', '#', '#', '#', '.', '#' },
{ '#', '.', '.', '.', '.', '.', '.', '#', '.', '.', '.', '#' },
{ '#', '#', '#', '#', '#', '#', '#', '#', '#', '#', '#', '#' }};

for ( unsigned int row =0; row < 12; row++)
{
        for (unsigned int col = 0; col < 12; col++)
                {
                cout << maze[row][col] << ' ' ;

                cout << endl;
                }


      [ See http://www.gotw.ca/resources/clcm.htm for info about ]
      [ comp.lang.c++.moderated.    First time posters: Do this! ]

"shadow427" <alisha427@netzero.com> writes:

> I am trying to print a 2d character array and its just not working.

What is not working? I.e. what do you expect to happen, and what does
happen effectively?

      [ See http://www.gotw.ca/resources/clcm.htm for info about ]
      [ comp.lang.c++.moderated.    First time posters: Do this! ]

* "shadow427" <alisha427@netzero.com>
| All that it prints now, is that it starts on line two and just
| prints one character at a time, which isn't right.
--<snip-snip>--
| for ( unsigned int row =0; row < 12; row++)
| {
|         for (unsigned int col = 0; col < 12; col++)
|                 {
|                 cout << maze[row][col] << ' ' ;
| 
|                 cout << endl;
|                 }

Should be obviuos, no?  Currently you're printing an endl after each
column.  Move the printing of 'endl' _after_ the col block.

R'

      [ See http://www.gotw.ca/resources/clcm.htm for info about ]
      [ comp.lang.c++.moderated.    First time posters: Do this! ]

> * "shadow427" <alisha427@netzero.com>
> | All that it prints now, is that it starts on line two and just
> | prints one character at a time, which isn't right.
> --<snip-snip>--
> | for ( unsigned int row =0; row < 12; row++)
> | {
> |         for (unsigned int col = 0; col < 12; col++)
> |                 {
> |                 cout << maze[row][col] << ' ' ;
> |
> |                 cout << endl;
> |                 }

Ralf Fassel wrote:
> Should be obviuos, no?  Currently you're printing an endl after each
> column.  Move the printing of 'endl' _after_ the col block.

Yes, Shadow, Ralf is right... in other words, check where your braces
are.


      [ See http://www.gotw.ca/resources/clcm.htm for info about ]
      [ comp.lang.c++.moderated.    First time posters: Do this! ]

You call cout<<endl after each character (in the inner loop).

for ( unsigned int row =0; row < 12; row++)
{
        for (unsigned int col = 0; col < 12; col++)
                {
                cout << maze[row][col] << ' ' ;
//              cout << endl;  // <-- remove from here
                }
        cout << endl; // <-- to here
}

By the way, if you add a column with zero-terminators, you can print
each row in single expression:

char maze[12][13] = {
  "#.#....##", // automatic way to make zero-terminated string
  {'#',......'#',0} // manual
  .....
};

for(int row=0; row<12; ++row)
  cout << maze[row] << endl;


      [ See http://www.gotw.ca/resources/clcm.htm for info about ]
      [ comp.lang.c++.moderated.    First time posters: Do this! ]

Kodt wrote:
>
> By the way, if you add a column with zero-terminators, you can print
> each row in single expression:
>
> char maze[12][13] = {
>   "#.#....##", // automatic way to make zero-terminated string
>   {'#',......'#',0} // manual
>   .....
> };
>
> for(int row=0; row<12; ++row)
>   cout << maze[row] << endl;

Just note that string literals should not be modified. :)
In other words, these two are not equivalent.

// maze[i][j] cannot be modified
char maze[12][13] = {
   "#.#....##",
   // ...
};

// maze[i][j] can be modified
char maze[12][13] = {
   {'#',......'#',0},
   // ...
};

-- 
Seungbeom Kim

      [ See http://www.gotw.ca/resources/clcm.htm for info about ]
      [ comp.lang.c++.moderated.    First time posters: Do this! ]

In article <dt63hf$biu$1@news.Stanford.EDU>, Seungbeom Kim 
<musiphil@bawi.org> writes
>Just note that string literals should not be modified. :)
>In other words, these two are not equivalent.
>
>// maze[i][j] cannot be modified
>char maze[12][13] = {
>   "#.#....##",
>   // ...
>};
>
>// maze[i][j] can be modified
>char maze[12][13] = {
>   {'#',......'#',0},
>   // ...
>};
Would you like to try to justify that? Leave out the distraction of a 
second dimension and look at:

char message[] = "help";
and
char message[] = {'h', 'e', 'l', 'p', '\0'};

and explain why you think those are not equivalent. Of course neither is 
equivalent to:

char * message = "help";

which despite the lack of a const qualifier results in message pointing 
to a non-modifiable array of char.

-- 
Francis Glassborow      ACCU
Author of 'You Can Do It!' see http://www.spellen.org/youcandoit
For project ideas and contributions: http://www.spellen.org/youcandoit/projects


      [ See http://www.gotw.ca/resources/clcm.htm for info about ]
      [ comp.lang.c++.moderated.    First time posters: Do this! ]

Francis Glassborow wrote:
> In article <dt63hf$biu$1@news.Stanford.EDU>, Seungbeom Kim 
> <musiphil@bawi.org> writes
>> Just note that string literals should not be modified. :)
>> In other words, these two are not equivalent.
>>
>> // maze[i][j] cannot be modified
>> char maze[12][13] = {
>>   "#.#....##",
>>   // ...
>> };
>>
>> // maze[i][j] can be modified
>> char maze[12][13] = {
>>   {'#',......'#',0},
>>   // ...
>> };
> Would you like to try to justify that? Leave out the distraction of a 
> second dimension and look at:
> 
> char message[] = "help";
> and
> char message[] = {'h', 'e', 'l', 'p', '\0'};
> 
> and explain why you think those are not equivalent. Of course neither is 
> equivalent to:
> 
> char * message = "help";
> 
> which despite the lack of a const qualifier results in message pointing 
> to a non-modifiable array of char.

Oops, that was my mistake; I thought that the first example
had an array of pointers, not an array of arrays of chars.

Thanks for pointing it out. :)

-- 
Seungbeom Kim

      [ See http://www.gotw.ca/resources/clcm.htm for info about ]
      [ comp.lang.c++.moderated.    First time posters: Do this! ]

On 15 Feb 2006 08:28:25 -0500, "shadow427" <alisha427@netzero.com>
wrote:

>I am trying to print a 2d character array and its just not working.
>What am I doing wrong? I think i may need a pointer, but I am not sure
>just how to do that.  All that it prints now, is that it starts on line
>two and just prints one character at a time, which isn't right.  Thanks
>in advance
>
>
>char maze[][12]=
>{{ '#', '#', '#', '#', '#', '#', '#', '#', '#', '#', '#', '#' },
>{ '#', '.', '.', '.', '#', '.', '.', '.', '.', '.', '.', '#' },
>{ '.', '.', '#', '.', '#', '.', '#', '#', '#', '#', '.', '#' },
>{ '#', '#', '#', '.', '#', '.', '.', '.', '.', '#', '.', '#' },
>{ '#', '.', '.', '.', '.', '#', '#', '#', '.', '#', '.', '.' },
>{ '#', '#', '#', '#', '.', '#', '.', '#', '.', '#', '.', '#' },
>{ '#', '.', '.', '#', '.', '#', '.', '#', '.', '#', '.', '#' },
>{ '#', '#', '.', '#', '.', '#', '.', '#', '.', '#', '.', '#' },
>{ '#', '.', '.', '.', '.', '.', '.', '.', '.', '#', '.', '#' },
>{ '#', '#', '#', '#', '#', '#', '.', '#', '#', '#', '.', '#' },
>{ '#', '.', '.', '.', '.', '.', '.', '#', '.', '.', '.', '#' },
>{ '#', '#', '#', '#', '#', '#', '#', '#', '#', '#', '#', '#' }};
>
>for ( unsigned int row =0; row < 12; row++)
>{
>        for (unsigned int col = 0; col < 12; col++)
>                {
>                cout << maze[row][col] << ' ' ;
>
Move this line:
>                cout << endl;
>                }
here:
>
(and add a '}' here.

      [ See http://www.gotw.ca/resources/clcm.htm for info about ]
      [ comp.lang.c++.moderated.    First time posters: Do this! ]